Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci skip] Guide: RESTful table formatting #2333

Merged
merged 1 commit into from
Oct 15, 2019
Merged

[ci skip] Guide: RESTful table formatting #2333

merged 1 commit into from
Oct 15, 2019

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Oct 15, 2019

Description
A few formatting improvements for the RESTful table.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • n/a Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner MGatner requested a review from jim-parry October 15, 2019 18:55
jim-parry
jim-parry reviewed Oct 15, 2019
View reviewed changes
Copy link
Contributor

@jim-parry jim-parry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, comprehensive albeit a bit unweildly.
Have you tried the user guide make, to see if the table lines up?

@MGatner
Copy link
Member Author

MGatner commented Oct 15, 2019

I actually don't know how 😮

Is that Sphinx?

@MGatner
Copy link
Member Author

MGatner commented Oct 15, 2019

I found it. Will check.

@MGatner
Copy link
Member Author

MGatner commented Oct 15, 2019

It's not working on macOS, I'll have to try it later on a server.

@jim-parry
Copy link
Contributor

I had to step out, but am back. WIll try it here

@jim-parry jim-parry merged commit 0b3f556 into codeigniter4:develop Oct 15, 2019
@jim-parry
Copy link
Contributor

Looks really good :)

@MGatner MGatner deleted the resource-table-format branch October 16, 2019 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-parry jim-parry jim-parry left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGatner @jim-parry