Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #1880, fixed a few typos and updated code style #1886

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Fixed issue #1880, fixed a few typos and updated code style #1886

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 68 additions & 19 deletions system/Commands/Server/Serve.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<?php

/**
* CodeIgniter
*
Expand Down Expand Up @@ -46,50 +45,100 @@
*
* Not testable, as it throws phpunit for a loop :-/
*
* @package CodeIgniter\Commands\Server
*
* @codeCoverageIgnore
*/
class Serve extends BaseCommand
{
/**
* Minimum PHP version
*
* @var string
*/
protected $minPHPVersion = '7.2';

protected $group = 'CodeIgniter';
protected $name = 'serve';
protected $description = 'Launchs the CodeIgniter PHP-Development Server.';
protected $usage = 'serve';
protected $arguments = [];
protected $options = [
/**
* Group
*
* @var string
*/
protected $group = 'CodeIgniter';

/**
* Name
*
* @var string
*/
protected $name = 'serve';

/**
* Description
*
* @var string
*/
protected $description = 'Launches the CodeIgniter PHP-Development Server.';

/**
* Usage
*
* @var string
*/
protected $usage = 'serve';

/**
* Arguments
*
* @var array
*/
protected $arguments = [];

/**
* Options
*
* @var array
*/
protected $options = [
'-php' => 'The PHP Binary [default: "PHP_BINARY"]',
'-host' => 'The HTTP Host [default: "localhost"]',
'-port' => 'The HTTP Host Port [default: "8080"]',
];

/**
* Run the server
*
* @param array $params Parameters
*
* @return void
*/
public function run(array $params)
{
// Valid PHP Version?
if (phpversion() < $this->minPHPVersion)
{
die("You PHP version must be {$this->minPHPVersion} or higher to run CodeIgniter. Current version: " . phpversion());
die('Your PHP version must be ' . $this->minPHPVersion .
' or higher to run CodeIgniter. Current version: ' . phpversion());
}

// Collect any user-supplied options and apply them
$php = CLI::getOption('php') ?? PHP_BINARY;
$host = CLI::getOption('host') ?? 'localhost';
$port = CLI::getOption('port') ?? '8080';
// Collect any user-supplied options and apply them.
$php = escapeshellarg(CLI::getOption('php')) ?? PHP_BINARY;
$host = escapeshellarg(CLI::getOption('host')) ?? 'localhost';
$port = escapeshellarg(CLI::getOption('port')) ?? '8080';

// Get the party started
CLI::write("CodeIgniter development server started on http://{$host}:{$port}", 'green');
// Get the party started.
CLI::write('CodeIgniter development server started on http://' . $host . ':' . $port, 'green');
CLI::write('Press Control-C to stop.');

// Set the Front Controller path as Document Root
$docroot = FCPATH;
// Set the Front Controller path as Document Root.
$docroot = escapeshellarg(FCPATH);

// Mimic Apache's mod_rewrite functionality with user settings
$rewrite = __DIR__ . '/rewrite.php';
// Mimic Apache's mod_rewrite functionality with user settings.
$rewrite = escapeshellarg(__DIR__ . '/rewrite.php');

// Call PHP's built-in webserver, making sure to set our
// base path to the public folder, and to use the rewrite file
// to ensure our environment is set and it simulates basic mod_rewrite.
passthru("{$php} -S {$host}:{$port} -t {$docroot} {$rewrite}");
passthru($php . ' -S ' . $host . ':' . $port . ' -t ' . $docroot . ' ' . $rewrite);
}

}