Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove php 7.3 from "allow_failures" in travis config #1649

Merged
merged 1 commit into from
Jan 10, 2019
Merged

remove php 7.3 from "allow_failures" in travis config #1649

merged 1 commit into from
Jan 10, 2019

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Jan 3, 2019 •
edited
Loading

Let see if it will make travis build success in php 7.3 env

Checklist:

  • Securely signed commits

@samsonasik samsonasik changed the title manual install xdebug in php 7.3 in travis manual install xdebug in php nightly in travis Jan 3, 2019
@samsonasik samsonasik changed the title manual install xdebug in php nightly in travis remove php 7.3 from "allow_failures" in travis config Jan 3, 2019
@samsonasik
Copy link
Member Author

Edit: php 7.3 already success in travis, so, I removed the php 7.3 from allow_failures config in .travis.yml

@samsonasik samsonasik force-pushed the manual-install-xdebug-php73 branch from 45895a4 to 11bc745 Compare January 3, 2019 18:00
@samsonasik
Copy link
Member Author

Green builds for php 7.1, 7.2, and 7.3:

screen shot 2019-01-04 at 4 12 15 am

@lonnieezell lonnieezell merged commit fa5549f into codeigniter4:develop Jan 10, 2019
@samsonasik samsonasik deleted the manual-install-xdebug-php73 branch January 10, 2019 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @lonnieezell