-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Vagrantfile #1459
Merged
Merged
Add Vagrantfile #1459
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b8c07b8
Add Vagrantfile
natanfelles bc8ecf1
Makes Vagrantfile workable
natanfelles 826a5dd
Back synced_folder type to rsync
natanfelles f3d4793
Add Directory section
natanfelles 1712ae9
Allow rsync use symlinks and prepare user guide requirements
natanfelles e0e99b1
Add php-zip
natanfelles 0e71060
Update Vagrantfile
natanfelles 4426258
Allow external access to Memcached and Redis
natanfelles 3bf4971
Update Apache config and add optional APT Proxy
natanfelles a395dd9
Display PHP errors
natanfelles 73450c8
Up memory to 1024 and add swap to low-memory systems
natanfelles 2277532
Rename Vagrantfile to Vagrantfile.dist
natanfelles File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Makes Vagrantfile workable
- Loading branch information
commit bc8ecf1e4f0f781d290d3f64da89116577455a19
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VM runs with 400MB, 308MB "stopped". Required ~600MB when running tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I run mine with 1024m. Probably overkill, but hoping/planning for near-complete code coverage eventually.
Is there much of a penalty specifying more memory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends on the user's machine. Thinking about taking up as little resources as possible, I started with 512MB, but PHPUnit broke for not having enough memory to do the coverage. I run again and saw that it occupies about 600MB at most (MySQLi driver). I increased 256MB.
Testing now with the SQLite3 driver, PHPUnit also could not gererate the code coverage:
I'll go up to 1024 and test again. But this seems to me a very high value, I'm thinking of maybe already letting in the script instructions to create a swap file, because the memory only rises so much when it's generating code coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SQLite3 with
database.tests.database = ':memory:'
...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Increased the default
vb.memory
to 1024 and added script to auto add 1GB of swap if the VM has low RAM.Tested using SQLite3 with
vb.memory = "512"
and no problem. It used ~120MB of swap during coverage.