Simplify how to get indexData from mysql/mariadb #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natanfelles
commented
Nov 10, 2018
| } | ||
|
|
||
| return $retval; | ||
| return $keys; |
There was a problem hiding this comment.
The tests are failing due to return the $keys indexes with the keys names. The test expect to be indexes as integers.
I think about return the indexes with the key names by default, then update the tests - what do you think? Thanks.
There was a problem hiding this comment.
With key names will not have issues with ordering, like:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow to get all mysql/mariadb index types (PRIMARY, INDEX, UNIQUE, FULLTEXT and SPATIAL) without regex. Currently was possible to get PRIMARY, INDEX, UNIQUE types.
Checklist: