Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop requirement from ~> 0.50.0 to ~> 0.72.0 #140

Merged
merged 3 commits into from
Jul 10, 2019

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jul 8, 2019

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 0.72

New features

Bug fixes

  • #7121: Fix Style/TernaryParentheses cop to allow safe navigation operator without parentheses. (@​timon)
  • #7063: Fix autocorrect in Style/TernaryParentheses cop. (@​parkerfinch)
  • #7106: Fix an error for Lint/NumberConversion when #to_i called on a variable on a hash. (@​koic)
  • #7107: Fix parentheses offence for numeric arguments with an operator in Style/MethodCallWithArgsParentheses. (@​gsamokovarov)
  • #7119: Fix cache with non UTF-8 offense message. (@​pocke)
  • #7118: Fix Style/WordArray with encoding: binary magic comment and non-ASCII string. (@​pocke)
  • #7159: Fix an error for Lint/DuplicatedKey when using endless range. (@​koic)
  • #7151: Fix Style/WordArray to also consider words containing hyphens. (@​fwitzke)
  • #6893: Handle implicit rescue correctly in Naming/RescuedExceptionsVariableName. (@​pocke, [@​anthony-robin][])
  • #7165: Fix an auto-correct error for Style/ConditionalAssignment when without else branch'. (@​koic)
  • #7171: Fix an error for Style/SafeNavigation when using unless nil? as a safeguarded'. (@​koic)
  • #7113: This PR renames EnforcedStyle: rails to EnabledStyle: outdented_access_modifiers for Layout/IndentationConsistency. (@​koic)
  • #7130: Skip autocorrect in Style/FormatString if second argument to String#% is a variable. (@​tejasbubane)
  • #7171: Fix an error for Style/SafeNavigation when using unless nil? as a safeguarded'. (@​koic)

Changes

  • #5976: Remove Rails cops. (@​koic)
  • #5976: Remove rubocop -R/--rails option. (@​koic)
  • #7113: Rename EnforcedStyle: rails to EnabledStyle: indented_internal_methods for Layout/IndentationConsistency. (@​koic)

[@​anthony-robin]: https://github.com/anthony-robin

Changelog

Sourced from rubocop's changelog.

0.72.0 (2019-06-25)

New features

Bug fixes

  • #7121: Fix Style/TernaryParentheses cop to allow safe navigation operator without parentheses. (@​timon)
  • #7063: Fix autocorrect in Style/TernaryParentheses cop. (@​parkerfinch)
  • #7106: Fix an error for Lint/NumberConversion when #to_i called on a variable on a hash. (@​koic)
  • #7107: Fix parentheses offence for numeric arguments with an operator in Style/MethodCallWithArgsParentheses. (@​gsamokovarov)
  • #7119: Fix cache with non UTF-8 offense message. (@​pocke)
  • #7118: Fix Style/WordArray with encoding: binary magic comment and non-ASCII string. (@​pocke)
  • #7159: Fix an error for Lint/DuplicatedKey when using endless range. (@​koic)
  • #7151: Fix Style/WordArray to also consider words containing hyphens. (@​fwitzke)
  • #6893: Handle implicit rescue correctly in Naming/RescuedExceptionsVariableName. (@​pocke, [@​anthony-robin][])
  • #7165: Fix an auto-correct error for Style/ConditionalAssignment when without else branch'. (@​koic)
  • #7171: Fix an error for Style/SafeNavigation when using unless nil? as a safeguarded'. (@​koic)
  • #7130: Skip autocorrect in Style/FormatString if second argument to String#% is a variable. (@​tejasbubane)
  • #7171: Fix an error for Style/SafeNavigation when using unless nil? as a safeguarded'. (@​koic)

Changes

  • #5976: Remove Rails cops. (@​koic)
  • #5976: Remove rubocop -R/--rails option. (@​koic)
  • #7113: Rename EnforcedStyle: rails to EnabledStyle: indented_internal_methods for Layout/IndentationConsistency. (@​koic)

0.71.0 (2019-05-30)

New features

  • #7084: Permit to specify TargetRubyVersion 2.7. (@​koic)
  • #7092: Node patterns can now use *, + and ? for repetitions. ([@​marcandre][])

Bug fixes

  • #7066: Fix Layout/AlignHash when mixed Hash styles are used. ([@​rmm5t][])
  • #7073: Fix false positive in Naming/RescuedExceptionsVariableName cop. (@​tejasbubane)
  • #7090: Fix Layout/EmptyLinesAroundBlockBody for multi-line method calls. ([@​eugeneius][])
  • #6936: Fix Layout/MultilineMethodArgumentLineBreaks when bracket hash assignment on multiple lines. ([@​maxh][])
  • Mark Layout/HeredocArgumentClosingParenthesis incompatible with Style/TrailingCommaInArguments. ([@​maxh][])

Changes

  • #5976: Warn for Rails Cops. (@​koic)
  • #5976: Warn for rubocop -R/--rails option. (@​koic)
  • #7078: Mark Lint/PercentStringArray as unsafe. ([@​mikegee][])
... (truncated)
Commits
  • 4135413 Cut 0.72
  • 445b342 [Fix #6793] Clarify ruby version error
  • ca01b3e [Fix #7171] Fix an error for Style/SafeNavigation
  • c897642 [Fix #7130] Skip autocorrect in Style/FormatString if second argument is va...
  • 97ff421 [Fix #7171] Fix an error for Style/SafeNavigation
  • efe9ab4 [Fix #6893] Handle implicit rescue correctly in Naming/RescuedExceptionsVaria...
  • 239e2b6 Allow safe-navigation in ternary conditions without parenthesis
  • de29e43 Handle URLs in inherit_from
  • 7e5c2b2 Add new cop Style/FloatDivision
  • c595654 [Fix #7165] Fix an error for Style/ConditionalAssignment
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it). To ignore the version in this PR you can just close it
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Jul 8, 2019
@dangerpr-bot
Copy link

dangerpr-bot commented Jul 8, 2019

1 Warning
⚠️ Unless you’re refactoring existing code or improving documentation, please update CHANGELOG.md.

Here's an example of a CHANGELOG.md entry:

* [#140](https://github.com/codegram/hyperclient/pull/140): Update rubocop requirement from ~> 0.50.0 to ~> 0.72.0 - [@dependabot-preview[bot]](https://github.com/dependabot-preview[bot]).

Generated by 🚫 Danger

@mrcasals
Copy link
Contributor

mrcasals commented Jul 8, 2019

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/rubocop-tw-0.72.0 branch from 291b152 to 05d8fc3 Compare July 8, 2019 12:45
Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v0.50.0...v0.72.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@mrcasals mrcasals force-pushed the dependabot/bundler/rubocop-tw-0.72.0 branch from d2625b0 to e1a34f7 Compare July 9, 2019 06:46
@mrcasals mrcasals force-pushed the dependabot/bundler/rubocop-tw-0.72.0 branch from e1a34f7 to 809fe1d Compare July 9, 2019 06:55
@mrcasals
Copy link
Contributor

mrcasals commented Jul 9, 2019

JRuby build is failing, reported it here: https://travis-ci.community/t/unable-to-test-against-jruby-9-2-7-0/3138/6

@mrcasals mrcasals force-pushed the dependabot/bundler/rubocop-tw-0.72.0 branch from cabcc73 to 809fe1d Compare July 9, 2019 09:21
@dblock
Copy link
Collaborator

dblock commented Jul 9, 2019

Personally I would vote for removing all those # frozen_string_literal: true and disabling this in .rubocop.yml.

@mrcasals
Copy link
Contributor

@dblock done!

@mrcasals
Copy link
Contributor

Build issues seem to be fixed now! 🎉

@mrcasals mrcasals merged commit 2698d6c into master Jul 10, 2019
@mrcasals mrcasals deleted the dependabot/bundler/rubocop-tw-0.72.0 branch July 10, 2019 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants