Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

public repo: token needed or not? #1035

Closed
gftea opened this issue Jul 31, 2023 · 7 comments
Closed

public repo: token needed or not? #1035

gftea opened this issue Jul 31, 2023 · 7 comments
Assignees
@thomasrockhu-codecov

Comments

@gftea
Copy link

gftea commented Jul 31, 2023

Hi,

I got below upload failure multiple times so far on my public repo. Is it still true that no token is needed for public repo?

Run codecov/codecov-action@v3
==> linux OS detected
https://uploader.codecov.io/latest/linux/codecov.SHA256SUM
==> SHASUM file signed by key id 806bb28aed[7](https://github.com/gftea/amqprs/actions/runs/5716535849/job/15488588129#step:8:8)79[8](https://github.com/gftea/amqprs/actions/runs/5716535849/job/15488588129#step:8:9)6[9](https://github.com/gftea/amqprs/actions/runs/5716535849/job/15488588129#step:8:10)
==> Uploader SHASUM verified (0c9b79[11](https://github.com/gftea/amqprs/actions/runs/5716535849/job/15488588129#step:8:12)9b0d8dbe7aaf460dc3bd7c3094ceda06e5ae32b0d11a8ff56e2cc5c5  codecov)
==> Running version latest
==> Running version v0.6.1
/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov -n  -Q github-action-3.1.4 -Z -f ./lcov.info
[2023-07-31T15:36:21.038Z] ['info'] 
     _____          _
    / ____|        | |
   | |     ___   __| | ___  ___ _____   __
   | |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
   | |___| (_) | (_| |  __/ (_| (_) \ V /
    \_____\___/ \__,_|\___|\___\___/ \_/

  Codecov report uploader 0.6.1
[2023-07-31T15:36:21.047Z] ['info'] => Project root located at: /home/runner/work/amqprs/amqprs
[2023-07-31T15:36:21.051Z] ['info'] -> No token specified or token is empty
[2023-07-31T15:36:21.058Z] ['info'] Searching for coverage files...
[2023-07-31T15:36:21.158Z] ['info'] => Found 1 possible coverage files:
  ./lcov.info
[2023-07-31T15:36:21.158Z] ['info'] Processing ./lcov.info...
[2023-07-31T15:36:21.194Z] ['info'] Detected GitHub Actions as the CI provider.
[2023-07-31T15:36:21.502Z] ['info'] Pinging Codecov: https://codecov.io/upload/v4?package=github-action-3.1.4-uploader-0.6.1&token=*******&branch=main&build=5716535849&build_url=https%3A%2F%2Fgithub.com%2Fgftea%2Famqprs%2Factions%2Fruns%2F5716535849%2Fjob%2F15488588[12](https://github.com/gftea/amqprs/actions/runs/5716535849/job/15488588129#step:8:13)9&commit=0a9c6350525b96036875d8f531255fe80633f918&job=codecov&pr=&service=github-actions&slug=gftea%2Famqprs&name=&tag=&flags=&parent=
[2023-07-31T[15](https://github.com/gftea/amqprs/actions/runs/5716535849/job/15488588129#step:8:16):36:[21](https://github.com/gftea/amqprs/actions/runs/5716535849/job/15488588129#step:8:22).672Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
Error: Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov' failed with exit code [25](https://github.com/gftea/amqprs/actions/runs/5716535849/job/15488588129#step:8:26)5
@willie-yao
Copy link

We are experiencing the same issue in our public repository: https://github.com/kubernetes-sigs/cluster-api-provider-azure/actions/runs/5715317747/job/15486532385?pr=3775

@willie-yao willie-yao mentioned this issue Jul 31, 2023
Closed
@jakoch jakoch mentioned this issue Sep 14, 2023
Closed
@slifty
Copy link
Contributor

slifty commented Sep 14, 2023 •
edited
Loading

I'm also curious about this -- the README says it is not needed, but the error indicates it is needed.

image

Would love guidance from the CodeCov team!

slifty added a commit to PhilanthropyDataCommons/service that referenced this issue Sep 14, 2023
@slifty
Use CODECOV_TOKEN secret
cbb7251 
The new version of Codecov seems to require tokens be set even for
public repositories; the secret was taken from the codecov website[1]
and added as a repository secret[2].  It isn't clear if this is intended
as required in the long term[3] but for now it appears to be.

[1] https://app.codecov.io/gh/PhilanthropyDataCommons/service/settings
[2] https://github.com/PhilanthropyDataCommons/service/settings/secrets/actions
[3] codecov/codecov-action#1035
slifty added a commit to PhilanthropyDataCommons/service that referenced this issue Sep 15, 2023
@slifty
Use CODECOV_TOKEN secret
df04138 
The new version of Codecov seems to require tokens be set even for
public repositories; the secret was taken from the codecov website[1]
and added as a repository secret[2].  It isn't clear if this is intended
as required in the long term[3] but for now it appears to be.

[1] https://app.codecov.io/gh/PhilanthropyDataCommons/service/settings
[2] https://github.com/PhilanthropyDataCommons/service/settings/secrets/actions
[3] codecov/codecov-action#1035
@dolfinus
Copy link

Probably the same as codecov/feedback#112

@thomasrockhu-codecov thomasrockhu-codecov self-assigned this Sep 27, 2023
@jeromedockes
Copy link

Probably the same as codecov/feedback#112

AFAICT codecov/feedback#112 is about codecov-action@v4; whereas here the problem occurs with v3.
Here are examples of the same error in other repositories:

https://github.com/skrub-data/skrub/actions/runs/6572632635/job/17854122133?pr=797#step:6:104

https://github.com/nilearn/nilearn/actions/runs/6572360256/job/17853342435?pr=4029#step:6:38

@thomasrockhu-codecov
Copy link
Contributor

@jeromedockes with v3, the token is not required, but due to GitHub rate limiting, it is strongly strongly recommended.

Closing this in favor of #1035

@dolfinus
Copy link

Closing this in favor of #1035

Probably wrong issue number, #1035 is the current issue.

@thomasrockhu-codecov
Copy link
Contributor

Yikes, thanks @dolfinus. Closing in favor of codecov/feedback#112

@LecrisUT LecrisUT mentioned this issue Dec 4, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomasrockhu-codecov thomasrockhu-codecov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@slifty @gftea @dolfinus @jeromedockes @willie-yao @thomasrockhu-codecov