-
-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(playwright): Clear cookie by name #4693
feat(playwright): Clear cookie by name #4693
Conversation
…ince Playwright 1.43)
…ince Playwright 1.43)
…ince Playwright 1.43)
…ince Playwright 1.43)
@ngraf PR looks good but tests failed. Could you check if it is needed to update Playwright in the pipeline? |
Hi @DavertMik , At least I am able to reproduce the failing Playwright helper test locally now after following the steps in the GitHub pipeline. |
…ince Playwright 1.43)
Alright. I fixed the tests. Now my final challenge is to resolve the branch conflict that arose in the meantime. That is a bit challenging for me, but I am confident I will resolve it .. somehow. |
Alright. I resolved all conflicts. I think we are good now. :) |
@@ -3,7 +3,7 @@ if none provided clears all cookies. | |||
|
|||
```js | |||
I.clearCookie(); | |||
I.clearCookie('test'); // Playwright currently doesn't support clear a particular cookie name | |||
I.clearCookie('test'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe it's worth mentioning since Playwright 1.43 so that this won't surprise anyone when they are using playwright < 1.43 and this doesn't work for them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's edge case, and I hope everyone will use latest PW
Motivation/Description of the PR
Applicable helpers:
Type of change
Checklist:
npm run docs
)->
npm run docs
does not work for me :/npm run lint
)->
npm run lint
does not work for me :/npm test
)->
npm test
does not work for me :/