Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to JUnit 5 jupiter #69

Closed
jonashackt opened this issue Jan 6, 2020 · 4 comments
Closed

Upgrade to JUnit 5 jupiter #69

jonashackt opened this issue Jan 6, 2020 · 4 comments

Comments

@jonashackt
Copy link
Member

Check, if Spring itself also uses JUnit 5 already - and then switch the starter also.
marcopaga added a commit that referenced this issue Oct 23, 2020
@marcopaga
#69 Migrated the starter to Junit 5 and also switched to AssertJ
34ad220
jonashackt added a commit that referenced this issue Jan 4, 2021
@jonashackt
Complete upgrade from JUnit 4 to JUnit 5 to support Spring Boot 2.4.x (…
d6db77c 
…#69). Also migrated from system-rules (JUnit 4 dependent) to system-stubs (and system-stubs-jupiter for a better JUnit5 integration). The examples are also tested with 2.4 version of the starter - but have to remain based on Spring Boot 2.3.x until the new version is released, since Configuration bean names changed in Spring Cloud, which blows the whole test suite (therefore also upgraded to spring-cloud-sleuth 3.x for Spring Boot 2.4.x compatibility). Only left hamcrest, where we needed to know if Strings are contained..
@jonashackt
Copy link
Member Author

@marcopaga sadly I didn't saw your branch with the whole work you already did 😭 with Spring Boot 2.4.x not shipping JUnit 4 anymore #90 I needed to have a full migration. What I found really cool is the system-stubs library as a modern alternative to system-rule. What is the magic behind AssertJ? I managed to migrate mostly everything to plain JUnit 5 - only the containsString stuff is left hamcrest dependent...

@marcopaga
Copy link
Contributor

Don't worry Jonas. 🙂 Great you found a modern alternative with system-stubs. I switched to AssertJ because of personal preference 😬.

@jonashackt
Copy link
Member Author

Ok, so we can close this for now and maybe philosophize later 🍻

@jonashackt jonashackt mentioned this issue Jan 7, 2021
Closed
@jonashackt
Copy link
Member Author

See also 57020a2 , d4f3875 and 3cd7829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcopaga @jonashackt