Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP [Issue 161] Hook up FE to the new auth endpoints #163

Closed
wants to merge 6 commits into from

Conversation

lpatmo
Copy link
Member

@lpatmo lpatmo commented Oct 1, 2020

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🎨 Enhancement
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Context

Placeholder example: This PR closes issue #12

Screenshots/Recordings (if there are UI changes)

Placeholder example: ![screenshot of new resource page](https://user-images.githubusercontent.com/43/23.png)

Note: you can upload a screenshot onto your PR and put it here.

Implementation Details - what was your thought process as you changed the code?

Placeholder example:
[x] Made an axios GET request to /resources
[x] Refactored to use useQuery library
[x] Wrote tests

Related Tickets & Documents (Optional)

Placeholder example: This relates to issue #23.

Filed issue #43 as a next step to do after this PR is merged.

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation (readme.md or contributing.md)?

  • 📜 readme.md
  • 📜 contributing.md
  • 🙅 no documentation needed
  • 🙋 I'd like someone to help write documentation, and will file a new issue for it

@lpatmo lpatmo force-pushed the issue-161-new-auth branch from 103117f to 049ac8a Compare October 22, 2020 04:45
@lpatmo lpatmo force-pushed the issue-161-new-auth branch from 1688623 to b01340c Compare October 22, 2020 05:36
@tgrrr
Copy link

tgrrr commented Oct 24, 2020

In register.js, it looks like there is still the ids passwords1 and 2

@stale
Copy link

stale bot commented Nov 23, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 23, 2020
@stale stale bot closed this Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants