This repository has been archived by the owner on Mar 29, 2023. It is now read-only.
Invoke plugin methods after permission is granted #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@l3ender Thank you for the contribution. Currently we don't actively maintain this plugin. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the scenario where a plugin method is invoked for the first time and permission has not yet been granted. In this scenario, the permission prompt will come, but the API that was requested will never be invoked.
The fix is to invoke the API method after permission has been granted.
My Swift is not strong so please offer any suggestions or fixes (particularly I am not positive on
selfvsweakSelfusage with closures).Note: it is easier to look at this PR if you ignore whitespace changes with ?w=1 parameter (https://github.com/codeborne/cordova-plugin-contacts/pull/5/files?w=1).