feat(nx-plugin): add executor to nx-plugin #737

BioPhoton · 2024-07-08T18:59:01Z

Precondition:
#740
closes #289

This PR includes:

add executor autorun
add executor utils
add format normalization

Not included in this PR:

e2e tests for the autorun executor
refactor(nx-plugin): async execution of the command and streaming logs and errors #761

Related to:
#63

# Conflicts: # e2e/nx-plugin-e2e/tests/configuration.e2e.test.ts # e2e/nx-plugin-e2e/tests/init.e2e.test.ts # e2e/nx-plugin-e2e/vite.config.e2e.ts # package-lock.json # packages/nx-plugin/project.json # packages/nx-plugin/src/generators/configuration/__snapshots__/generator.integration.test.ts.snap # packages/nx-plugin/src/generators/configuration/files/code-pushup.config.ts.template # packages/nx-plugin/src/generators/configuration/generator.integration.test.ts # packages/nx-plugin/src/generators/configuration/generator.ts # testing/test-utils/src/index.ts

# Conflicts: # README.md # e2e/nx-plugin-e2e/project.json

github-actions · 2024-07-08T19:04:07Z

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 9ce99d0 with source commit a08978e.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Performance	🔴 48	🔴 44
Code coverage	🟡 90	🟡 90
Accessibility	🟢 91	🟢 91	–
Best Practices	🟢 100	🟢 100	–
SEO	🟡 61	🟡 61	–
Bug prevention	🟢 100	🟢 100	–
Code style	🟢 99	🟢 99	–
Security	🟢 100	🟢 100	–
Updates	🟡 79	🟡 79	–
Custom checks	🟡 67	🟡 67	–

🗃️ Groups

👎 2 groups regressed

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Lighthouse	Performance	🔴 48	🔴 44
Code coverage	Code coverage metrics	🟡 90	🟡 90

18 other groups are unchanged.

🛡️ Audits

👍 4 audits improved, 👎 4 audits regressed, 12 audits changed without impacting score

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
Lighthouse	Largest Contentful Paint	🟨 3.5 s	🟨 3.9 s
Lighthouse	Speed Index	🟥 7.2 s	🟥 8.2 s
Lighthouse	First Contentful Paint	🟥 3.2 s	🟥 3.2 s
Lighthouse	Time to Interactive	🟥 20.4 s	🟥 17.7 s
Lighthouse	First Meaningful Paint	🟨 3.2 s	🟨 3.2 s
Code coverage	Line coverage	🟩 91.6 %	🟩 91.3 %
Code coverage	Branch coverage	🟨 83.8 %	🟨 83.6 %
Code coverage	Function coverage	🟩 92.3 %	🟩 92.4 %
Lighthouse	Avoids enormous network payloads	🟩 Total size was 1,789 KiB	🟩 Total size was 1,782 KiB
Lighthouse	Total Blocking Time	🟥 13,220 ms	🟥 9,530 ms
Lighthouse	Metrics	🟩 20417	🟩 17653
Lighthouse	JavaScript execution time	🟥 13.2 s	🟥 11.4 s
Lighthouse	Minimizes main-thread work	🟥 26.3 s	🟥 24.7 s
Lighthouse	Max Potential First Input Delay	🟥 3,290 ms	🟥 3,980 ms
Lighthouse	Server Backend Latencies	🟩 380 ms	🟩 130 ms
Lighthouse	Eliminate render-blocking resources	🟥 Potential savings of 1,420 ms	🟥 Potential savings of 1,510 ms
Lighthouse	Initial server response time was short	🟩 Root document took 410 ms	🟩 Root document took 360 ms
Lighthouse	Network Round Trip Times	🟩 60 ms	🟩 20 ms
Lighthouse	Uses efficient cache policy on static assets	🟨 27 resources found	🟨 27 resources found
Lighthouse	Avoids an excessive DOM size	🟥 2,184 elements	🟥 2,185 elements

489 other audits are unchanged.

packages/models/src/lib/upload-config.unit.test.ts

.github/workflows/code-pushup.yml

# Conflicts: # packages/cli/src/lib/implementation/core-config.middleware.ts # packages/cli/src/lib/implementation/core-config.middleware.unit.test.ts

# Conflicts: # packages/nx-plugin/src/executors/internal/cli.ts # packages/nx-plugin/src/executors/internal/cli.unit.test.ts # packages/utils/src/lib/transform.unit.test.ts

packages/models/code-pushup.config.ts

packages/models/project.json

packages/nx-plugin/mock/utils/executor.ts

packages/nx-plugin/src/executors/autorun/Readme.md

packages/nx-plugin/src/executors/autorun/executor.ts

packages/nx-plugin/src/executors/autorun/utils.ts

testing/test-utils/src/lib/utils/nx.ts

nx.json

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>

BioPhoton added 12 commits April 15, 2024 21:06

feat(nx-plugin): add basic executor

870fc10

wip

fb701fd

wip

cd143ec

wip

405a47b

refactor(nx-plugin): polish executor logic

d630581

wip

922f2bc

feat(nx-plugin): adjust executor

c8f68ee

Merge branch 'main' into add-executor-to-nx-plugin

34e16fd

# Conflicts: # README.md # e2e/nx-plugin-e2e/project.json

feat(nx-plugin): fix lint

1f21131

feat(nx-plugin): fix unit-test

3827a3c

wip

cf78b86

github-actions bot assigned BioPhoton Jul 8, 2024

github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 cli 🧩 core 🧩 models 🧩 utils 🧩 nx-plugin 🛠️ tooling labels Jul 8, 2024

wip

d9858db

BioPhoton added 3 commits July 8, 2024 21:17

wip

aae0ad0

wip

0cc5154

wip

75943a4

BioPhoton commented Jul 8, 2024

View reviewed changes

packages/models/src/lib/upload-config.unit.test.ts Outdated Show resolved Hide resolved

BioPhoton added 3 commits July 8, 2024 21:26

wip

1e83a23

wip

25c2249

wip

2565427

wip

8de874a

BioPhoton commented Jul 21, 2024

View reviewed changes

.github/workflows/code-pushup.yml Outdated Show resolved Hide resolved

Update .github/workflows/code-pushup.yml

2c7011a

github-actions bot removed the 🦾 CI/CD continuous integration and deployment label Jul 21, 2024

BioPhoton added 2 commits July 22, 2024 10:21

Merge branch 'main' into add-executor-to-nx-plugin

ff9613b

# Conflicts: # packages/cli/src/lib/implementation/core-config.middleware.ts # packages/cli/src/lib/implementation/core-config.middleware.unit.test.ts

refactor(utils): support nested objects in cliObjToArgs

b534f23

github-actions bot added the 🧩 utils label Jul 22, 2024

BioPhoton added 2 commits July 22, 2024 11:30

refactor(utils): fix lint

d1c960c

refactor(utils): fix format

6c270d3

github-actions bot removed the 🧩 cli label Jul 22, 2024

BioPhoton mentioned this pull request Jul 22, 2024

feat(utils): add nested objects to cli args parsing #758

Merged

Merge branch 'main' into add-executor-to-nx-plugin

a1d03f1

# Conflicts: # packages/nx-plugin/src/executors/internal/cli.ts # packages/nx-plugin/src/executors/internal/cli.unit.test.ts # packages/utils/src/lib/transform.unit.test.ts

github-actions bot removed the 🧩 utils label Jul 22, 2024

BioPhoton added 3 commits July 22, 2024 12:26

refactor(nx-plugin): fix error logging

069372f

refactor: fix main and configure models cp config

e576eb7

refactor: format

0ce701d

BioPhoton requested a review from matejchalk July 23, 2024 11:37

BioPhoton added 2 commits July 23, 2024 13:45

refactor: types

1126253

refactor: lint

4df20f5

matejchalk reviewed Jul 23, 2024

View reviewed changes

BioPhoton and others added 7 commits July 23, 2024 15:29

Update packages/nx-plugin/src/executors/autorun/executor.ts

06dd2b6

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>

Merge branch 'main' into add-executor-to-nx-plugin

94afcbc

test(test-utils): remove default value for project name

eae02e2

Update packages/nx-plugin/src/executors/autorun/utils.ts

e7aedb6

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>

rename

02794d7

fix typo

009d6f2

remove config

8764e8e

matejchalk approved these changes Jul 24, 2024

View reviewed changes

BioPhoton merged commit ba4f181 into main Jul 24, 2024
30 checks passed

BioPhoton deleted the add-executor-to-nx-plugin branch July 24, 2024 09:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(nx-plugin): add executor to nx-plugin #737

feat(nx-plugin): add executor to nx-plugin #737

BioPhoton commented Jul 8, 2024 •

edited

Loading

github-actions bot commented Jul 8, 2024 •

edited

Loading

feat(nx-plugin): add executor to nx-plugin #737

feat(nx-plugin): add executor to nx-plugin #737

Conversation

BioPhoton commented Jul 8, 2024 • edited Loading

github-actions bot commented Jul 8, 2024 • edited Loading

Code PushUp

🏷️ Categories

🗃️ Groups

🛡️ Audits

BioPhoton commented Jul 8, 2024 •

edited

Loading

github-actions bot commented Jul 8, 2024 •

edited

Loading