Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

getContainer() must be public #16

Closed
hirakujira opened this issue Apr 2, 2021 · 4 comments
Closed

getContainer() must be public #16

hirakujira opened this issue Apr 2, 2021 · 4 comments
Assignees
@williamdes
Milestone
1.6.2

Comments

@hirakujira
Copy link

Since laravel 8.33.1, getContainer() function must be public

Reference: laravel/framework@90fbaa7
@williamdes
Copy link
Member

Thank you for the notice
I will apply that if it does not break anything

@hirakujira
Copy link
Author

hirakujira commented Apr 3, 2021 •
edited
Loading

I'm not sure whether it breaks anything, but it would show error and not compatible with laravel 8.33.1 and newer versions if the function keeps private.

@williamdes
Copy link
Member

Yup, as far as I can see on https://laravel.com/api/5.8/Illuminate/Support/Manager.html and the actual code there is no getContainer defined, that allow me to change the function signature to what I want 🎉

@williamdes williamdes self-assigned this Apr 3, 2021
@williamdes williamdes added this to the 1.6.2 milestone Apr 3, 2021
williamdes added a commit that referenced this issue Apr 3, 2021
@williamdes
Add a CHANGELOG entry for #16
d306231
@williamdes
Copy link
Member

I released 1.6.2 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
None yet
Milestone
1.6.2
Development

No branches or pull requests
2 participants
@hirakujira @williamdes