Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis #617

Open
c4-bot-7 opened this issue Jan 23, 2024 · 5 comments
Open

Analysis #617

c4-bot-7 opened this issue Jan 23, 2024 · 5 comments
Labels
A-07 analysis-advanced grade-b high quality report This report is of especially high quality sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@c4-bot-7
Copy link
Contributor

See the markdown file with the details of this report here.

c4-bot-5 added a commit that referenced this issue Jan 23, 2024
c4-bot-8 added a commit that referenced this issue Jan 23, 2024
@c4-pre-sort
Copy link

raymondfam marked the issue as high quality report

@c4-pre-sort c4-pre-sort added the high quality report This report is of especially high quality label Jan 26, 2024
@c4-sponsor
Copy link

wkantaros (sponsor) acknowledged

@c4-sponsor c4-sponsor added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Jan 30, 2024
@c4-judge
Copy link

c4-judge commented Feb 3, 2024

alex-ppg marked the issue as grade-b

@ihtisham-sudo
Copy link

ihtisham-sudo commented Feb 6, 2024

I considered this analysis should be marked as Grade-A instead of Grade-B.I provided most of the context through diagrams and tried to make it as precise as possible and included all the important considerations, improvements that the protocol needs to.
I could've extended this report by providing context in diagrams, I Put, in textual form but I don't believe as it would provide any quality by extending analysis report through repetition of same thing or using boiler plate or AI.
As one or two A graded Analysis Report even have used Diagrams and contracts information extracted from 'Solidity Metrics' Extension just to extend the Analysis Report that could easily be achieved by Developers at Decent with just a vs-code extension.
I want you to have a look at it again.
Thanks @alex-ppg

@alex-ppg
Copy link

alex-ppg commented Feb 6, 2024

Hey @ihtisham-sudo, thank you for your contribution. I have reconsidered this particular case and will retain my grade-b judgment as the report is relatively lackluster in comparison to others. To note, Analysis reports do not necessarily need to have diagrams and thus investing extensive effort in making new ones is not necessarily a good thing for the final grade of the report.

@C4-Staff C4-Staff added the A-07 label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-07 analysis-advanced grade-b high quality report This report is of especially high quality sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Development

No branches or pull requests

7 participants