Unchecked low level call #480
Labels
2 (Med Risk)
Assets not at direct risk, but function/availability of the protocol could be impacted or leak value
bug
Something isn't working
duplicate-25
insufficient quality report
This report is not of sufficient quality
unsatisfactory
does not satisfy C4 submission criteria; not eligible for awards
Lines of code
https://github.com/code-423n4/2024-01-decent/blob/main/src/UTBExecutor.sol#L67
https://github.com/code-423n4/2024-01-decent/blob/main/src/UTBExecutor.sol#L54
Vulnerability details
Impact
This is a well-known issue but has not been listed in Automated findings [1],[2].
The call/delegatecall function returns a boolean value indicating whether the call was successful. However, it is important to note that this return value is not being checked in the current implementation.
As a result, there is a possibility that the call wasn't successful, while the transaction continues without reverting.
refund may lose their extraNative and amount.
Proof of Concept
https://github.com/code-423n4/2024-01-decent/blob/main/src/UTBExecutor.sol#L54
https://github.com/code-423n4/2024-01-decent/blob/main/src/UTBExecutor.sol#L67
Tools Used
Recommended Mitigation Steps
check return value
Assessed type
call/delegatecall
The text was updated successfully, but these errors were encountered: