Unchecked Return Values #325
Labels
2 (Med Risk)
Assets not at direct risk, but function/availability of the protocol could be impacted or leak value
bug
Something isn't working
duplicate-641
insufficient quality report
This report is not of sufficient quality
unsatisfactory
does not satisfy C4 submission criteria; not eligible for awards
Lines of code
https://github.com/code-423n4/2024-01-decent/blob/main/src/UTBExecutor.sol#L70
Vulnerability details
Impact
Detailed description of the impact of this finding.
Unchecked Return Values: The contract does not check the return value of the transferFrom and transfer calls for ERC20 tokens. It is important to check these return values to ensure that the transfers were successful.
Proof of Concept
Provide direct links to all referenced code in GitHub. Add screenshots, logs, or any other relevant proof that illustrates the concept.
(success, ) = target.call(payload);
Tools Used
Recommended Mitigation Steps
check the success with require statement.
Assessed type
Token-Transfer
The text was updated successfully, but these errors were encountered: