Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a line in the Mac installation for apple silicon #123

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

multitudes
Copy link
Contributor

I hope I am not too pedantic :) My small contribution. Nothing too big.
Whan I installed the MLX42 on my Mac and had the error 'GLFW/glfw3.h' file not found. Of course I updated the ~/.zshrc file . I later read that you compile the path to homebrew lib. The opt however is only for apple silicon. People on older Macs donor really need to do anything.
So the line -L"/opt/homebrew/Cellar/glfw/3.3.8/lib/" is redundant and might not work for Intel Mac users but I left it in. Did not want to disrupt too much!

Thanks for the library! I am currently finishing my fractal program with it both on Linux and on Mac(at home)

@W2Wizard W2Wizard added Documentation Improvements or additions to documentation Fix Fixed or resolved an issue labels Jan 23, 2024
Copy link
Collaborator

@W2Wizard W2Wizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ➜ ~ were purely decorative but I can see now that they can be annoying when trying to just paste in the command.

Copy link
Collaborator

@W2Wizard W2Wizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit: 👍

@W2Wizard
Copy link
Collaborator

Only one future request and also tip, try to keep the commit messages somewhere below 50 characters. Nobody wants to read essays in their commits 😂

@W2Wizard W2Wizard merged commit d8d9a35 into codam-coding-college:master Jan 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Fix Fixed or resolved an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants