Fix for android clients that do not expect encrypted connections

[Ottoz1]

This pull request includes a small change to the ADBTcpDevice implementation in the adb_client module. The changes solve a problem for android devices that refuse to talk over STLS and respond with CNXN previously causing the error WrongResponseReceived("CNXN", "STLS")

Mind taking a look at it? :)

[cocool97]

Thanks for your PR :)

On what device/version have you tested it ? I didn't know devices could communicate on unencrypted channels like that 😅

[Ottoz1]

Im on a pretty custom android screen (not even able to adjust brightness) android 11, and running adb_client 2.1.7. Was only able to test the code for unencrypted connections, but should work identically for normal encrypted devices. I basically just seperated out the (messages.header.command) and matched it against two message types, CNXN and STLS instead of previously only STLS, all logic for the STLS case is copied from the previous iteration. I also added a warn! when connecting unsecurely. Even if its ultimately up to the client, how the client want's to communicate, but feels weird not mentioning it in some log.

Im very surprised as well, no one mentions anything related to using adb unencrypted. And googles adb documentation... Leaves much to be desired 😆. But following the original ADB servers communication with my device on wireshark shows that ADB handles it even though its never mentioned thats its an option directly.

[cocool97]

Yes the code looks good to me, I only need to test encrypted communication and I'll merge :)

This is indeed kinda weird, I haven't tested the TCP device on versions older than A13, so this is likely something common for old versions 🤷
Haven't seen anything in the documentation as well...