Skip to content
This repository has been archived by the owner on Apr 12, 2023. It is now read-only.

Fixed to retry if there is an error in Payload #902

Merged
3 commits merged into from
Mar 8, 2022
Merged

Conversation

ghost
Copy link

@ghost ghost commented Mar 7, 2022

Issue 番号 / Issue ID

  • Close #

目的 / Purpose

  • AndroidのSafetyNetのAttestation APIでまれに発生するエラーの際に、解消することを期待してリトライする。

変更内容 / Changes

  • AndroidのSafetyNetのAttestation APIでまれにエラーが返される事がある

    {
        "apkCertificateDigestSha256": [],
        "error": "internal_error"
    }
  • エラーの際は正常なものが返される様になることを期待しリトライを実施する

    • リトライは3回実施する
    • 間隔は4秒→8秒→16秒とする
  • リトライを行ってもなおエラーの場合はエラーダイアログを表示する

破壊的変更をもたらしますか / Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request の種類 / Pull Request type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

確認事項 / What to check

  • [ ]

その他 / Other information


Internal IDs:
Bug 3775

@ghost ghost force-pushed the feature/jwt-error branch from 42d74c6 to c14f30f Compare March 7, 2022 07:10
@ghost ghost requested review from cocoa-dev005, a user and cocoa-dev003 March 7, 2022 07:12
@ghost ghost self-assigned this Mar 7, 2022
@ghost ghost marked this pull request as ready for review March 7, 2022 07:13
Copy link
Contributor

@cocoa-dev005 cocoa-dev005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ghost ghost merged commit 993b59d into develop Mar 8, 2022
@ghost ghost deleted the feature/jwt-error branch March 8, 2022 05:23
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants