-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add support for OpenBSD #2341
Comments
It looks like we don't currently support OpenBSD. However, we do support FreeBSD. $ GOOS=openbsd go build -o /tmp/pebble ./cmd/pebble
# github.com/cockroachdb/pebble/vfs
vfs/disk_usage_unix.go:18:27: stat.Bsize undefined (type "golang.org/x/sys/unix".Statfs_t has no field or method Bsize)
vfs/disk_usage_unix.go:18:48: stat.Bfree undefined (type "golang.org/x/sys/unix".Statfs_t has no field or method Bfree)
vfs/disk_usage_unix.go:19:28: stat.Bsize undefined (type "golang.org/x/sys/unix".Statfs_t has no field or method Bsize)
vfs/disk_usage_unix.go:19:49: stat.Bavail undefined (type "golang.org/x/sys/unix".Statfs_t has no field or method Bavail)
vfs/disk_usage_unix.go:20:28: stat.Bsize undefined (type "golang.org/x/sys/unix".Statfs_t has no field or method Bsize)
vfs/disk_usage_unix.go:20:49: stat.Blocks undefined (type "golang.org/x/sys/unix".Statfs_t has no field or method Blocks)
$ GOOS=freebsd go build -o /tmp/pebble ./cmd/pebble && echo $?
0 Perhaps we should consider adding support. I'll repurpose this issue slightly to track that work. Thank you for raising! |
stat.Bsize undefined | stat.Bfree undefined | stat.Bsize undefined | stat.Bavail undefined
Looks like on OpenBSD the field names are slightly different. This shouldn't be too hard to fix. We'll likely just need to add a |
We should also add a build target for this in our CI pipeline. Perhaps Free and OpenBSD could be part of a CI matrix. |
- Add vfs/disk_usage_openbsd.go to use unix.Statfs with specific fields for OpenBSD - Fix bug #2341 Signed-off-by: Laurent Cheylus <foxy@free.fr>
Pebble is a requirement for httpx, and thus during installation it ejected the following set of errors, which immediately caused the installation to fail.:
System: OpenBSD Current 7.2
Go Version: go1.19.4 openbsd/amd64
Any information to further help diagnose the issue would be greatly appreciated.
Jira issue: PEBBLE-128
The text was updated successfully, but these errors were encountered: