-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ccl/sqlproxyccl: add PROXY protocol support via CLI flag to sqlproxy #99429
ccl/sqlproxyccl: add PROXY protocol support via CLI flag to sqlproxy #99429
Conversation
502e09d
to
892f092
Compare
d43d841
to
e3aa3f3
Compare
I'll figure out how to fix
|
e3aa3f3
to
fb66f43
Compare
This PR is ready for a review as the flakes have been fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This commits adds a new `require-proxy-protocol` flag to `mt start-proxy`, and that changes the sqlproxy's behavior to support the PROXY protocol. When the flag is set, the protocol will be enforced on the SQL listener, and supported on a best-effort basis on the HTTP listener. If the PROXY protocol isn't used, but is enforced, the connection will be rejected. The rationale behind doing best-effort basis on the HTTP listener is that some healthcheck systems don't support the protocol. This work is needed for the AWS PrivateLink work in CockroachCloud, which requires the use of the PROXY protocol. Release note: None Epic: none Release justification: SQL Proxy change only. Changes are needed for the AWS PrivateLink work in CockroachCloud.
fb66f43
to
374ed5e
Compare
TFTR! bors r=pjtatlow |
This PR was included in a batch that was canceled, it will be automatically retried |
Build failed (retrying...): |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 374ed5e to blathers/backport-release-22.2-99429: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This commits adds a new
require-proxy-protocol
flag tomt start-proxy
, andthat changes the sqlproxy's behavior to support the PROXY protocol. When the
flag is set, the protocol will be enforced on the SQL listener, and supported
on a best-effort basis on the HTTP listener. If the PROXY protocol isn't used,
but is enforced, the connection will be rejected. The rationale behind doing
best-effort basis on the HTTP listener is that some healthcheck systems don't
support the protocol.
This work is needed for the AWS PrivateLink work in CockroachCloud, which
requires the use of the PROXY protocol.
Release note: None
Epic: none
Release justification: SQL Proxy change only. Changes are needed for the AWS
PrivateLink work in CockroachCloud.