sql/pgwire: close cancel request conn as soon as possible #76476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than closing in the defer block, do it sooner. This is because some clients (e.g. PGJDBC rely on timeout behavior where the connection is closed as soon as the request data is read. Release note: None
|
This change is |
otan
approved these changes
Feb 13, 2022
| // entirely new connection that's created just to send the cancel. We close | ||
| // the connection as soon as possible after reading the data, since there | ||
| // is nothing to send back to the client. | ||
| _ = conn.Close() |
There was a problem hiding this comment.
it may be worth logging this error somewhere just in case
There was a problem hiding this comment.
hm, i'd prefer not to. the client is also allowed to close the conn first. even apart from that i don't feel that it's that actionable if this errors out
|
tftr! bors r=otan |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #76231
Rather than closing in the defer block, do it sooner. This is because
some clients (e.g. PGJDBC) rely on timeout behavior where the connection
is closed as soon as the request data is read.
Release note: None