storage: Resolve intents when encountering an aborted txn #5946
Conversation
|
LGTM Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed. storage/replica_command.go, line 571 [r1] (raw file): storage/replica_command.go, line 589 [r1] (raw file): Comments from Reviewable |
This is a follow-up of #5885. Resolve local intents and update the transaction record when we attempt to roll back the transaction and find that it has already been aborted. Define helper method resolveExplicitIntents and call it.
7c9e044 to
53644ae
Compare
|
Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions. storage/replica_command.go, line 571 [r1] (raw file): storage/replica_command.go, line 589 [r1] (raw file): Comments from Reviewable |
| } | ||
| } | ||
|
|
||
| // Persist the transaction record with updated status (& possibly timestamp). |
There was a problem hiding this comment.
It's weird that everything that happens from here on down happens inside of this helper method. Auto-gc'ing can easily move outside. Writing an updated txn entry can maybe stay, but the method name needs to indicate that this is happening (and nobody can write another entry in EndTransaction after this one unless it reads the entry from disk first).
|
Had some late comments - sorry for not looking earlier. |
|
Sure! Will send another PR to address the comment. |
|
Thanks Kenji, appreciate it. On Mon, Apr 11, 2016 at 11:00 AM Kenji Kaneda notifications@github.com
-- Tobias |
This is a follow-up of #5885. Resolve local intents and update the transaction record when we attempt to roll back the transaction and find that it has already been aborted.
Define helper method 1resolveExplicitIntents` and call it.
This change is