Reduce scanner/queue load #5251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
store.go change LGTM, but as discussed offline (and in #5252) let's remove the gc_queue.go change and instead modify the thresholds on the previous two lines |
13a0a3e to
322328d
Compare
|
Done (and tests fixed), PTAL |
| // A contribution of 1 from gc, 10/5 from intents. | ||
| {bc, bc * ttl, 5, 10 * ia, now, true, 1 + 2}, | ||
| {bc, bc * ttl, 5, 10 * ia, now, true, (1 + 2) * considerThreshold}, |
There was a problem hiding this comment.
You could move these multiplications down to the point where you compare against test.priority so it's not repeated on every line.
|
LGTM |
- Set (arbitrary) threshold for GC queue Avoid the queue periodically scanning the whole Replica without actually getting to delete much. The limit is arbitrary. Fine-tuning ideas welcome. - Disable MaxIdleTime for the consistency scanner This avoids costly recurrent runs of the consistency checker at 5 minute intervals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is