Mtracy/sub navigation #2009
Merged
Mtracy/sub navigation #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -133,7 +133,7 @@ module Components { | |||
| m("th", | |||
| { | |||
| onclick: (e: any): void => this.SetSortColumn(col), | |||
| className: this.IsSortColumn(col) ? sortClass : null | |||
| className: this.IsSortColumn(col) ? sortClass : "" | |||
There was a problem hiding this comment.
it was actually assigning class="null" to the html elements. With this, the class is actually blank.
b88ec46 to
d54c9f2
Compare
|
LGTM |
added 2 commits
August 6, 2015 16:49
In the latest design wireframes, certain UI pages are composed of multiple "Tabs" - for example, the page for a single Node will have an "Overview" tab and a "Graphs" tab. Navigation between these tabs is accomplished via a Navigation Bar component, which is the same component used for the main navigation bar. Finally, the content on the various page tabs has been restructured to more closely resemble the current wireframes.
The field name of this structure was changed by cockroachdb#1976, but it has since been decided that "address" is a more accurate name than "string".
d54c9f2 to
4e32c31
Compare
|
Disregard comma comments, see palantir/tslint#557 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add per-page "tab" navigation from admin UI: