Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: disable raft pre-vote #18128

Merged
merged 1 commit into from
Sep 1, 2017

Conversation

irfansharif
Copy link
Contributor

In light of issues blue and adriatic ran into this week hitting 0
QPS and maintaining non-zero MsgPreVote{,Resp} message counts thereon
forth. Disable it ahead of the v1.1 branch cut.

+cc @bdarnell, merge when approved, I'll be AFK today morning.

In light of issues `blue` and `adriatic` ran into this week hitting 0
QPS and maintaining non-zero MsgPreVote{,Resp} message counts thereon
forth. Disable it ahead of the v1.1 branch cut.
@irfansharif irfansharif requested a review from a team September 1, 2017 10:52
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@a-robinson a-robinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, even if only due to the rolling upgrade concerns not being worked out.

We'll still need to understand what's been happening, though.

@irfansharif irfansharif merged commit 16711d1 into cockroachdb:master Sep 1, 2017
@irfansharif irfansharif deleted the revert-pre-vote branch September 1, 2017 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants