Consider implementing the Delimited interface in protoutil.JSONPb and ProtoPb #20925
Comments
johanbrandhorst
added a commit
to johanbrandhorst/cockroach
that referenced
this issue
Dec 21, 2017
Implement the Delimited interface for the gogo/protobuf JSONPb and ProtoPb marshallers. Fixes cockroachdb#20925
johanbrandhorst
added a commit
to johanbrandhorst/cockroach
that referenced
this issue
Dec 21, 2017
Implement the Delimited interface for the gogo/protobuf JSONPb and ProtoPb marshallers. Fixes cockroachdb#20925
johanbrandhorst
added a commit
to johanbrandhorst/cockroach
that referenced
this issue
Dec 22, 2017
Implement the Delimited interface for the gogo/protobuf JSONPb marshaller. Fixes cockroachdb#20925
johanbrandhorst
added a commit
to johanbrandhorst/cockroach
that referenced
this issue
Dec 22, 2017
Implement the Delimited interface for the gogo/protobuf JSONPb marshaller. Fixes cockroachdb#20925
johanbrandhorst
added a commit
to johanbrandhorst/cockroach
that referenced
this issue
Dec 22, 2017
Implement the Delimited interface for the gogo/protobuf JSONPb marshaller. Fixes cockroachdb#20925
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The grpc-gateway introduced a new interface that marshallers probably want to implement:
Delimited. It is used to determine what delimiter to use when sending a stream of messages. I imagine for the JSON marshaller we'll want to use\nlike the default grpc-gateway one does, not sure about the proto marshaller though, maybe\nthere as well.This is in https://github.com/cockroachdb/cockroach/blob/faf9cbd87c60fce3466a109c621c18762b88f450/pkg/util/protoutil/jsonpb_marshal.go for reference.
The text was updated successfully, but these errors were encountered: