Use noVNC via patternfly-react #8894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e579cd6 to
051f913
Compare
This was referenced Apr 20, 2018
331c15b to
ebaab76
Compare
|
Rebased, since #8402 and patternfly/patternfly-react#288 changed |
ebaab76 to
4225c4d
Compare
1 task
|
This requires full |
4225c4d to
c8a200a
Compare
martinpitt
approved these changes
Sep 23, 2018
|
Looks like this breaks testInlineConsole, this probably changed identifiers and such which needs to be adjusted in the tests. |
c8a200a to
d9f746d
Compare
Leverage reusable component wraping noVNC. Closes cockpit-project#8894
Reference on old noVNC (prior 1.0.0 introduced newly by patternfly-react) is removed.
|
Adjusted the tests. |
martinpitt
pushed a commit
that referenced
this pull request
Sep 23, 2018
Leverage reusable component wraping noVNC. Closes #8894
garrett
pushed a commit
to garrett/cockpit
that referenced
this pull request
Oct 17, 2018
Leverage reusable component wraping noVNC. Closes cockpit-project#8894
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The in-browser VNC component is externalized to patternfly-react for it's wider reuse by other projects.
With this change, the noVNC dependency version is updated to
1.0.0from recent0.6.2.Checklist:
VncConsolein patternfly-react); increase patternfly-react version accordinglyVncConsolecomponentReactinstead ofreact-litesince later versions of patternfly-react require it (i.e. use of<Fragment>)