-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bots, test: Introduce rhel-8-1-distropkg mode #12735
Conversation
@Gundersanne: Does this failure ring a bell? When I replace After changing that locally, it still fails on
Do you have some time to take a look here? |
@martinpitt I think this should fix it: croissanne@9d0ca51 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests is green which is great, but I see some inconsistency - whether we are dropping rhel-8-0-distropkg all together (I think this is the goal) or we want to keep it but just not to run it automatically (which this PR breaks).
We will use this to test the rhel-8-appstream branch as well as z-stream updates. This will also ensure that we don't break the wire protocol. This replaces the obsolete rhel-8-0-distropkg. Move the test map to rhel-8-1-distropkg by default for master. Closes cockpit-project#12735
@marusak : I now added cleanup of 8.0 and rearranged the commits a bit. Can you please have another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo, but otherwise looks good :)
master will drop support for RHEL 8.0. Run the stable rhel-8.0 branch tests on rhel-8-0 image refreshes.
This will live on in the rhel-8.0 branch. Drop all test special cases and the rhel-8-0-distropkg install mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
rhel-8-0-distropkg failure is expected, as this PR just takes this away. debian-testing failure is unrelated. |
We will use this to test the rhel-8-appstream branch as well as z-stream updates. This will also ensure that we don't break the wire protocol. This replaces the obsolete rhel-8-0-distropkg. Move the test map to rhel-8-1-distropkg by default for master. Closes #12735
We will use this to test the rhel-8-appstream branch as well as z-stream
updates. This will also ensure that we don't break the wire protocol.