Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bots, test: Introduce rhel-8-1-distropkg mode #12735

Merged
merged 3 commits into from
Sep 10, 2019

Conversation

martinpitt
Copy link
Member

@martinpitt martinpitt commented Sep 9, 2019

We will use this to test the rhel-8-appstream branch as well as z-stream
updates. This will also ensure that we don't break the wire protocol.

  • Add rhel-8-1-distropkg test skips

@martinpitt martinpitt added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Sep 9, 2019
@martinpitt
Copy link
Member Author

@Gundersanne: Does this failure ring a bell? When I replace .listing-ct-actions with .listing-ct, it works. But I didn't see an obvious change of that between 196 and master?

After changing that locally, it still fails on

  File "test/verify/check-networking-firewall", line 406, in removeZone
    b.wait_not_present("#zones-listing tr[data-row-id='{}']".format(zone))

Do you have some time to take a look here?

@croissanne
Copy link
Contributor

@martinpitt I think this should fix it: croissanne@9d0ca51

@martinpitt martinpitt removed no-test For doc/workflow changes, or experiments which don't need a full CI run, test-external labels Sep 9, 2019
@martinpitt martinpitt marked this pull request as ready for review September 9, 2019 13:54
Copy link
Member

@marusak marusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests is green which is great, but I see some inconsistency - whether we are dropping rhel-8-0-distropkg all together (I think this is the goal) or we want to keep it but just not to run it automatically (which this PR breaks).

We will use this to test the rhel-8-appstream branch as well as z-stream
updates. This will also ensure that we don't break the wire protocol.

This replaces the obsolete rhel-8-0-distropkg. Move the test map to
rhel-8-1-distropkg by default for master.

Closes cockpit-project#12735
@martinpitt
Copy link
Member Author

@marusak : I now added cleanup of 8.0 and rearranged the commits a bit. Can you please have another look?

@martinpitt martinpitt requested a review from marusak September 10, 2019 05:47
Copy link
Member

@marusak marusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, but otherwise looks good :)

master will drop support for RHEL 8.0. Run the stable rhel-8.0 branch
tests on rhel-8-0 image refreshes.
This will live on in the rhel-8.0 branch. Drop all test special cases
and the rhel-8-0-distropkg install mode.
Copy link
Member

@marusak marusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinpitt
Copy link
Member Author

rhel-8-0-distropkg failure is expected, as this PR just takes this away. debian-testing failure is unrelated.

@martinpitt martinpitt merged commit 1bd419a into cockpit-project:master Sep 10, 2019
martinpitt added a commit that referenced this pull request Sep 10, 2019
We will use this to test the rhel-8-appstream branch as well as z-stream
updates. This will also ensure that we don't break the wire protocol.

This replaces the obsolete rhel-8-0-distropkg. Move the test map to
rhel-8-1-distropkg by default for master.

Closes #12735
@martinpitt martinpitt deleted the r81dp branch September 10, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants