session: Fix custom cockpit kerberos keytab with krb5 > 1.17 #12732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After 1.17, krb5 moved to using `secure_getenv()` for environment variables [1], in particular for `$KRB5_KTNAME`. This results in the value being ignored, as cockpit-session is suid. Use the `gss_acquire_cred_from()` GSSAPI extension [2] instead. This is available since krb5 1.11, so adjust the version check in configure.ac accordingly. The days of broken krb5 pkg-config are long gone, so just use that properly. [1] krb5/krb5@d439e370b70 [2] https://k5wiki.kerberos.org/wiki/Projects/Credential_Store_extensions#gss_acquire_cred_from.28.29 Fixes cockpit-project#12730 Closes cockpit-project#12732
2d46d37 to
96fc7d1
Compare
|
I made this nicer by always using |
mvollmer
approved these changes
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After 1.17, krb5 moved to using
secure_getenv()for environment variables[1], in particular for
$KRB5_KTNAME. This results in the value being ignored,as cockpit-session is suid.
Use the
gss_acquire_cred_from()GSSAPI extension [2] instead. This isavailable since krb5 1.11, so adjust the version check in configure.ac
accordingly. The days of broken krb5 pkg-config are long gone, so just
use that properly.
[1] krb5/krb5@d439e370b70
[2] https://k5wiki.kerberos.org/wiki/Projects/Credential_Store_extensions#gss_acquire_cred_from.28.29
Fixes #12730