[S90-JAVA] Avoid use of static in interface

src/java-plugin/src/main/java/fr/cnumr/java/RulesList.java

@@ -59,7 +59,8 @@ public static List<Class<? extends JavaCheck>> getJavaChecks() {
                 AvoidUsingGlobalVariablesCheck.class,
                 AvoidSetConstantInBatchUpdate.class,
                 FreeResourcesOfAutoCloseableInterface.class,
-                AvoidMultipleIfElseStatement.class
+                AvoidMultipleIfElseStatement.class,
+                AvoidUseOfStaticInInterface.class
         ));
     }
 

src/java-plugin/src/main/java/fr/cnumr/java/checks/AvoidUseOfStaticInInterface.java

@@ -0,0 +1,45 @@
+package fr.cnumr.java.checks;
+
+import org.sonar.check.Priority;
+import org.sonar.check.Rule;
+import org.sonar.plugins.java.api.IssuableSubscriptionVisitor;
+import org.sonar.plugins.java.api.tree.*;
+
+import javax.annotation.Nonnull;
+import java.util.Arrays;
+import java.util.List;
+
+@Rule(
+        key = "S90",
+        name = "Developpement",
+        description = AvoidUseOfStaticInInterface.MESSAGE_RULE,
+        priority = Priority.MINOR,
+        tags = {"bug"})
+public class AvoidUseOfStaticInInterface extends IssuableSubscriptionVisitor {
+
+    public static final String MESSAGE_RULE = "Avoid use of static in interface.";
+
+    private final UseInterfaceVisitor VISITOR = new UseInterfaceVisitor();
+
+    @Override
+    public List<Tree.Kind> nodesToVisit() {
+        return Arrays.asList(Tree.Kind.INTERFACE);
+    }
+
+    @Override
+    public void visitNode(@Nonnull Tree tree) {
+        tree.accept(VISITOR);
+    }
+
+    private class UseInterfaceVisitor extends BaseTreeVisitor {
+        @Override
+        public void visitVariable(@Nonnull VariableTree tree) {
+            if (tree.symbol().isStatic()) {
+                reportIssue(tree, MESSAGE_RULE);
+            } else {
+                super.visitVariable(tree);
+            }
+        }
+    }
+
+}

src/java-plugin/src/main/resources/fr/cnumr/l10n/java/rules/java/S90.html

@@ -0,0 +1,19 @@
+<p>
+    Avoid use of static in interface. Prefer the use of Enum.
+</p>
+<h2>Noncompliant Code Example</h2>
+<pre>
+    public interface Color {
+        public static final int RED = 0xff0000;// Noncompliant
+        public static final int BLACK = 0x000000;// Noncompliant
+        public static final int WHITE = 0xffffff;// Noncompliant
+    }
+</pre>
+<h2>Compliant Code Example</h2>
+<pre>
+    public enum Color {
+        RED(0xff0000),// Compliant
+        BLACK(0x000000),// Compliant
+        WHITE(0xffffff);// Compliant
+    }
+</pre>

src/java-plugin/src/main/resources/fr/cnumr/l10n/java/rules/java/S90.json

@@ -0,0 +1,13 @@
+{
+  "title": "Avoid use of static in interface.",
+  "type": "CODE_SMELL",
+  "status": "ready",
+  "remediation": {
+    "func": "Constant\/Issue",
+    "constantCost": "20min"
+  },
+  "tags": [
+    "eco-conception"
+  ],
+  "defaultSeverity": "Minor"
+}

src/java-plugin/src/test/files/AvoidUseOfStaticInInterface.java

@@ -0,0 +1,11 @@
+package fr.cnumr.java.utils;
+
+public class AvoidUseOfStaticInInterface {
+
+    public interface Color {
+        public static final int RED = 0xff0000;// Noncompliant
+        public static final int BLACK = 0x000000;// Noncompliant
+        public static final int WHITE = 0xffffff;// Noncompliant
+    }
+
+}

src/java-plugin/src/test/files/GoodUsageOfEnumInsteadOfInterface.java

@@ -0,0 +1,11 @@
+package fr.cnumr.java.utils;
+
+public class AvoidUseOfStaticInInterface {
+
+    public enum Color {
+        RED,// Compliant
+        BLACK,// Compliant
+        WHITE;// Compliant
+    }
+
+}

src/java-plugin/src/test/java/fr/cnumr/java/MyJavaFileCheckRegistrarTest.java

@@ -34,7 +34,7 @@ void checkNumberRules() {
 		final MyJavaFileCheckRegistrar registrar = new MyJavaFileCheckRegistrar();
 		registrar.register(context);
 
-    assertThat(context.checkClasses()).hasSize(19);
+    assertThat(context.checkClasses()).hasSize(20);
     assertThat(context.testCheckClasses()).isEmpty();
   }
 }

src/java-plugin/src/test/java/fr/cnumr/java/checks/AvoidUseOfStaticInInterfaceTest.java

@@ -0,0 +1,23 @@
+package fr.cnumr.java.checks;
+
+import org.junit.jupiter.api.Test;
+import org.sonar.java.checks.verifier.JavaCheckVerifier;
+
+public class AvoidUseOfStaticInInterfaceTest {
+
+    @Test
+    public void checkNonCompliantTests() {
+        JavaCheckVerifier.newVerifier()
+                .onFile("src/test/files/AvoidUseOfStaticInInterface.java")
+                .withCheck(new AvoidUseOfStaticInInterface())
+                .verifyIssues();
+    }
+
+    @Test
+    public void checkCompliantTests() {
+        JavaCheckVerifier.newVerifier()
+                .onFile("src/test/files/GoodUsageOfEnumInsteadOfInterface.java")
+                .withCheck(new AvoidUseOfStaticInInterface())
+                .verifyNoIssues();
+    }
+}