This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Automate CodeNarc build from Maven's initialize #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mvn initialize` will now call the gradle build for CodeNarc, thus reducing the number of necessary steps to start working on the project. The initialize can be run on the root project. The only side-effect is that it will start two jacoco-maven-plugin:prepare-agent. Those don't affect the build, but they could be avoided by changing their execution phase (maybe a phase that would execute it only if tests are run?). .gradle has been added to the root .gitignore (since the command is not run from the same place and results in a .gradle folder that is not ignored), and comments and a new rule have been added.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mvn initializewill now call the gradle build for CodeNarc, thus reducing the number of necessary steps to start working on the project.The initialize can be run on the root project. The only side-effect is that it will start two jacoco-maven-plugin:prepare-agent. Those don't affect the build, but they could be avoided by changing their execution phase (maybe a phase that would execute it only if tests are run?).
.gradle has been added to the root .gitignore (since the command is not run from the same place and results in a .gradle folder that is not ignored), and comments and a new rule have been added.
This proposal aims to relieve the complexity highlighted in #47 .
A possible enhancement would be to make it so those steps only happen when manually called. A solution for that would be to extract those steps in a
build-codenarcprofile that could only be activated manually (mvn initialize -Pbuild-codenarc).