Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on windows #546

Merged
merged 11 commits into from
Mar 4, 2025
Merged

Fix on windows #546

merged 11 commits into from
Mar 4, 2025

Conversation

cnlohr
Copy link
Owner

@cnlohr cnlohr commented Mar 3, 2025

No description provided.

@cnlohr
Copy link
Owner Author

cnlohr commented Mar 4, 2025

@CaiB
I think I want to accept this wholesale. I just have two questions:

  1. Does it make sense to have two separate install scripts? One for user and one for system?
  2. Is there any way to make it so a user can "double-click" or "right-click-and" to invoke the installer?

@cnlohr
Copy link
Owner Author

cnlohr commented Mar 4, 2025

Eh, I am going to accept this because I really need it, and we can worry about other specifics later.

@cnlohr cnlohr merged commit a0f6afd into master Mar 4, 2025
166 checks passed
@cnlohr cnlohr deleted the fix_on_windows branch March 5, 2025 00:14
@CaiB
Copy link
Collaborator

CaiB commented Mar 5, 2025

Does it make sense to have two separate install scripts? One for user and one for system?

Not really, the code is pretty much the same, and being able to specify user, system, or specific path with one script seems like a better idea, and doesn't risk one getting out of date later on.

Is there any way to make it so a user can "double-click" or "right-click-and" to invoke the installer?

Yes, this is possible as-is, assuming they want to user-install (the default). Here's what that looks like (I just ran this in a fresh VM):
xpack_user_rightclick

If they want to system-install, then they'd need to run it from a terminal to provide the launch argument.

Note that the same caveat as Install-TCC with execution policies applies, which blocks PowerShell scripts from running by default unless a user changes this setting. The right-click-to-run approach bypasses this, but running from the terminal won't.

@cnlohr
Copy link
Owner Author

cnlohr commented Mar 5, 2025

WOOT!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants