Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update headers #522

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Update headers #522

merged 3 commits into from
Feb 12, 2025

Conversation

recalci
Copy link
Contributor

@recalci recalci commented Feb 11, 2025

Added a version table.
Updated v003, v10x, and x035 to their latest versions.

@cnlohr
Copy link
Owner

cnlohr commented Feb 11, 2025

Build is failing, need to resolve before merging.

@recalci
Copy link
Contributor Author

recalci commented Feb 11, 2025

Sorry, I missed this.
Some registers and bit positions that are not present in x035 were used. I am working on it.

@cnlohr
Copy link
Owner

cnlohr commented Feb 11, 2025

@recalci be liberal in what you include, for the sake of simplicity, and common code, you can include additional definitions that are not actually in the processor. That's better than having a swiss cheese of application.

/***************** Bit definition for AFIO_EXTICR1 register *****************/
#define AFIO_EXTICR1_EXTI0 ((uint16_t)0x00000003) /* EXTI 0 configuration */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh oops! Thanks for fixing!

@recalci
Copy link
Contributor Author

recalci commented Feb 11, 2025

@recalci be liberal in what you include, for the sake of simplicity, and common code, you can include additional definitions that are not actually in the processor. That's better than having a swiss cheese of application.

Understood. I'll adjust it to align with your guidance.

Additionally, remove CH32V30x_D8C related macro
Update all peripheral headers except USB and USBPD.
Update all peripheral headers except USB.
@cnlohr cnlohr merged commit 8ba9981 into cnlohr:master Feb 12, 2025
83 checks passed
@cnlohr
Copy link
Owner

cnlohr commented Feb 12, 2025

Merged. Thank you for the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants