-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert ch32v003fun -> ch32fun #506
Conversation
cnlohr
commented
Feb 3, 2025
- Split apart header into specific hardware devices.
* Split apart header into specific hardware devices.
I still need to make sure this all works, but, I'd like some more eyeballs on this. |
I'll take a close look tonight (UTC+1) |
I suggest considering splitting headers by peripherals, same as WCH’s official approach. We can use ch32xxxhw.h to manage which peripherals are available for specific model. This might make merging, updating, and checking easier. |
I can confirm it to work with ch32v208. No errors, just works. |
No. This would make it way too voluminous. EDIT: Also all the peripherals are subtly different on each architecture. Additionally, I want these files to be something people can use as a quick reference to see what features a given processor has instead of having to trull through lots of headers. |
Do we want to include changes to ch32fun.c, reorganizing how we setup the default ISR + startup code is organized. (+ changing the printf-by-default code in the hard-fault-handler) |
What do you mean by reorganizing? |
Right now, if you look at the vector table, and .start code, it is difficult to tell what is used where. CC @dwillmore |
I did think it could get split out, yes.
…On Mon, Feb 3, 2025 at 3:13 PM cnlohr ***@***.***> wrote:
Right now, if you look at the vector table, and .start code, it is
difficult to tell what is used where.
CC @dwillmore <https://github.com/dwillmore>
—
Reply to this email directly, view it on GitHub
<#506 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACPEX7BTDI5327NRMRHNFML2N7EVVAVCNFSM6AAAAABWLPOD3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZRHE3TGNBRHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
All projects on 003, 035 and 203 I have are working fine with the changes |
Do you think we should make more deep changes in ch32fun.c before committing this? Or commit this as is since it will match the new structure and people can begin to develop against it, and we can rename the repository. |
…pen to install newlib deliberately. But, don't default to allowing it by default.
IMHO we should do changes step by step. I don't see any reasons to make one giant commit instead of a series of commits. |
I checked my 003 project. Built and ran ok, but its about 100bytes larger? |
Nevermind. False Alarm. Blink seems ok. I will investigate my own app code, i must have changed something. |
I will squash and merge this this evening if there are no other concerns. |