Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubescape self-assessment #1424

Merged

Conversation

slashben
Copy link
Contributor

@slashben slashben commented Dec 6, 2024

Kubescape project is getting itself prepared for the Incubation phase. We are completing our first self-assessment.

Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for tag-security ready!

Name Link
🔨 Latest commit b3394d3
🔍 Latest deploy log https://app.netlify.com/sites/tag-security/deploys/675892748ef1b20009e7c665
😎 Deploy Preview https://deploy-preview-1424--tag-security.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@matthyx matthyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good starting point, thanks Ben!

Signed-off-by: Ben <ben@armosec.io>

Update community/assessments/projects/kubescape/self-assessment.md

Co-authored-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Ben Hirschberg <59160382+slashben@users.noreply.github.com>
Update community/assessments/projects/kubescape/self-assessment.md

Co-authored-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Ben Hirschberg <59160382+slashben@users.noreply.github.com>
Update community/assessments/projects/kubescape/self-assessment.md

Co-authored-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Ben Hirschberg <59160382+slashben@users.noreply.github.com>
Update community/assessments/projects/kubescape/self-assessment.md

Co-authored-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Ben Hirschberg <59160382+slashben@users.noreply.github.com>
Update with review comment and spelling fixes

Signed-off-by: Ben <ben@armosec.io>

Fixing Markdown lints

Signed-off-by: Ben <ben@armosec.io>

Spell exceptions

Signed-off-by: Ben <ben@armosec.io>

URL fix

Signed-off-by: Ben <ben@armosec.io>

Fixing links

Signed-off-by: Ben <ben@armosec.io>
@slashben slashben force-pushed the kubescape-self-assesment-first-version branch from af33477 to 1b19b56 Compare December 8, 2024 18:13
@slashben slashben marked this pull request as ready for review December 8, 2024 18:20
Signed-off-by: Ben <ben@armosec.io>
slashben and others added 7 commits December 10, 2024 08:33
Co-authored-by: Craig Box <craig.box@gmail.com>
Signed-off-by: Ben Hirschberg <59160382+slashben@users.noreply.github.com>
Co-authored-by: Craig Box <craig.box@gmail.com>
Signed-off-by: Ben Hirschberg <59160382+slashben@users.noreply.github.com>
Co-authored-by: Craig Box <craig.box@gmail.com>
Signed-off-by: Ben Hirschberg <59160382+slashben@users.noreply.github.com>
Co-authored-by: Craig Box <craig.box@gmail.com>
Signed-off-by: Ben Hirschberg <59160382+slashben@users.noreply.github.com>
Co-authored-by: Craig Box <craig.box@gmail.com>
Signed-off-by: Ben Hirschberg <59160382+slashben@users.noreply.github.com>
Co-authored-by: Craig Box <craig.box@gmail.com>
Signed-off-by: Ben Hirschberg <59160382+slashben@users.noreply.github.com>
Signed-off-by: Ben <ben@armosec.io>
Copy link
Collaborator

@JustinCappos JustinCappos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few very minor points. Basically ready to merge.

Would need a bunch more clarity to be ready for a joint assessment (especially around failure modes when different actors are compromised). Right now, it's a pretty solid first look at the project, though.

@eddie-knight
Copy link
Collaborator

This is well formed and thorough in all the right places! Happy to hit the merge button as soon as Justin's comments are resolved.

slashben and others added 2 commits December 10, 2024 18:56
Co-authored-by: Eddie Knight <knight@linux.com>
Signed-off-by: Ben Hirschberg <59160382+slashben@users.noreply.github.com>
Signed-off-by: Ben <ben@armosec.io>
@slashben
Copy link
Contributor Author

This is well formed and thorough in all the right places! Happy to hit the merge button as soon as Justin's comments are resolved.

@eddie-knight @JustinCappos merged(/updated with) your comments 🙏🏼

Signed-off-by: Ben <ben@armosec.io>
@JustinCappos JustinCappos merged commit 4641327 into cncf:main Dec 10, 2024
10 checks passed
@slashben slashben deleted the kubescape-self-assesment-first-version branch December 11, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants