Trigger streetview 'layoutChange' #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…open due to delayed startup
tmcgee
reviewed
Jun 28, 2017
viewer/js/gis/dijit/StreetView.js
Outdated
|
|
||
| // trigger layout change since parentWidget might | ||
| // already be open | ||
| this.onLayoutChange(this.parentWidget.open); |
There was a problem hiding this comment.
Should this be at line 73 within the if (this.parentWidget.toggleable) { statement?
…cmv-app into fix/StreetView-parentWidget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since parent widget may already be open due to delayed startup
Description
Calls the widget's layout change when the widget is started. onOpen isn't called initially otherwise because the startup is delayed.
Checklist
grunt lintproduces no error messages