Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make default config path configureable #686

Merged
merged 3 commits into from
Mar 3, 2017
Merged

make default config path configureable #686

merged 3 commits into from
Mar 3, 2017

Conversation

green3g
Copy link
Member

@green3g green3g commented Mar 3, 2017

In app.js you can do something like this:

var app = new App({
    configPath: 'myConfig/path',
    defaultConfig: 'explorerApp'
});

Rather than having to write a custom mixin just to change the path to the config folder. 

@tmcgee
Copy link
Member

tmcgee commented Mar 3, 2017

I can perhaps see the value of wanting to change the config file name to something other than viewer.js

For the config path, why wouldn't you just change that in the packages array up at the top of app.js? Doesn't that accomplish the same thing?

@green3g
Copy link
Member Author

green3g commented Mar 3, 2017

Yep, that would work, I didn't think about that method

@tmcgee tmcgee merged commit 1408666 into develop Mar 3, 2017
@tmcgee tmcgee deleted the modular-config branch March 3, 2017 20:43
@tmcgee tmcgee added this to the v2.0.0-beta.1 milestone Mar 3, 2017
green3g added a commit to cmv/cmv-docs that referenced this pull request Mar 6, 2017
tmcgee added a commit to cmv/cmv-docs that referenced this pull request Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants