Fix titlePane issue effecting IE 11/M.S. Edge and now Chrome v 55 #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et go of the titlePane when mouse is released.
|
@tmcgee Nice work! Thanks for being on top of this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Chrome version 55 (in the Chrome beta and dev channels), a floating titlePane widget does not stop dragging when the mouse is released. This is the same behavior previously experienced in IE 11 and MS Edge. Version 55 is expected to be released to the Chrome stable channel on December 6th.
I believe the issue is related to this dojo bug. Based on that report, this PR overrides the
onMouseUpin dojo Mover class. The fix has been tested with the effected browser versions as well as Firefox.