Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new _createMap method to allow custom mixins to override #499

Merged
merged 4 commits into from
Jan 14, 2016

Conversation

tmcgee
Copy link
Member

@tmcgee tmcgee commented Jan 13, 2016

the method.

This is useful when using CMV with BootstrapMap
(https://github.com/Esri/bootstrap-map-js).

@tmcgee
Copy link
Member Author

tmcgee commented Jan 13, 2016

It looks like the way travis handles eslint has changed and it is now complaining about a duplicate rule key. The rule is in fact a duplicate so I will remove and add to this PR.

@tmcgee
Copy link
Member Author

tmcgee commented Jan 13, 2016

@DavidSpriggs this is ready to go now.

Note to self: The GitHub+Travis process has changed but that is a good thing.

DavidSpriggs added a commit that referenced this pull request Jan 14, 2016
Add new `_createMap` method to allow custom mixins to override
@DavidSpriggs DavidSpriggs merged commit a385dfa into develop Jan 14, 2016
@DavidSpriggs DavidSpriggs deleted the feature/add-new-createMap_method branch January 14, 2016 12:02
@tmcgee tmcgee added this to the v1.4.0 milestone Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants