Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor patches to handle irregular database state #36

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Minor patches to handle irregular database state #36

merged 3 commits into from
Jun 14, 2022

Conversation

sei-jbritton
Copy link
Contributor

API-only change to address 2 minor bugs that were identified recently regarding destroyed TopoMojo gamespaces and _initialscore_ challenges in the database with no State JSON.

Fixes:

  1. Safely handle error from TopoMojo API during reset session. If a TopoMojo gamespace is deleted for any reason, there may be errors when Gameboard attempts to contact TopoMojo looking for that specific id. During "Reset Session", it is okay if the Gamespace is no longer there, but it must not fail and prevent the session from being reset. It now catches any errors and puts a default value instead.
  2. Ignore initialscore challenges in list function since null State may cause errors. When a team advances to another game with score there is a hidden challenge record containing that previous score to be added to the new session score. This challenge record has no State JSON and cannot be parsed when trying to access fields from it. These are now filtered out.

Copy link
Collaborator

@sei-mkaar sei-mkaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Foundry Appliance 👍

@sei-mkaar sei-mkaar merged commit d114857 into main Jun 14, 2022
@sei-mkaar sei-mkaar deleted the patches branch June 14, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants