-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return api server host and db host info from diagnostic endpt #1343
Conversation
'serving_host': serving_host, | ||
'database_host': db_host, | ||
} | ||
return make_response(json.dumps(response_data), 200, {'content-type': 'text/plain'}) |
Check failure
Code scanning / SonarCloud
Endpoints should not be vulnerable to reflected cross-site scripting (XSS) attacks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
false positive! i already fixed this in a way suggested by sonarcloud: by changing the content-type
@melange396 Is this protected in some way so that only Delphi users or systems can request it? |
@korlaxxalrok Tis! The |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
im mostly curious about the stickiness of the connections between the api server and the load balanced db hosts (i imagine each thread may connect to a different db backend, and that this can change as those connections are closed and reestablished)