Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to signals in rate-limit exempt list #1334

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Conversation

melange396
Copy link
Collaborator

  • preemptively adds nchs-mortality:deaths_covid_incidence_prop into the ratelimit-exempt signal set
  • changes hospital admissions override signal for county-level visualizations to an active/current signal (from a dsew-cpr to hospital-admissions:smoothed_adj_covid19_from_claims)
  • adds a fix to include override signals in the ratelimit-exempt set
  • fixes tests to work around changes to exemption status of above signals

…s code to also exempt substituted/override signals that was previously missing
@melange396 melange396 requested a review from dsweber2 November 3, 2023 18:05
Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@dsweber2 dsweber2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly got stuck down a rabbit hole trying to make the requests for these myself. smoothed_adj_covid19_from_claims does have data with a time value of oct 29 (missing Alaska and Montana for some reason), so seems like a decent display candidate. Otherwise I'm trusting the tests

@dsweber2 dsweber2 merged commit 5b36ff2 into dev Nov 3, 2023
@dsweber2 dsweber2 deleted the preemptive_signal_update branch November 3, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants