Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent "308 PERMANENT REDIRECT" via client change #1330

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Prevent "308 PERMANENT REDIRECT" via client change #1330

merged 1 commit into from
Oct 26, 2023

Conversation

rzats
Copy link
Contributor

@rzats rzats commented Oct 26, 2023

Closes #1320.

Summary:

Appends a trailing slash to URLs requested by the Python client, which should prevent an automatic redirect and an extra request to the server.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@melange396
Copy link
Collaborator

great, thanks!

@melange396 melange396 merged commit ea84e37 into dev Oct 26, 2023
@melange396 melange396 deleted the rzatserkovnyi/postfix-slash branch October 26, 2023 15:45
@melange396 melange396 mentioned this pull request Nov 3, 2023
Merged
@melange396 melange396 mentioned this pull request May 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melange396 melange396 melange396 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prevent "308 PERMANENT REDIRECT" via client change
2 participants
@rzats @melange396