Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to modify rate limiting for perftests #1324

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Add option to modify rate limiting for perftests #1324

merged 1 commit into from
Oct 24, 2023

Conversation

rzats
Copy link
Contributor

@rzats rzats commented Oct 24, 2023 •
edited
Loading

Summary:

Adds an option to the makefile to override the default rate limit. Also applies this option to the perftest rig.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rzats rzats requested a review from korlaxxalrok October 24, 2023 14:44
korlaxxalrok
korlaxxalrok approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@korlaxxalrok korlaxxalrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rzats rzats merged commit e5fafd4 into dev Oct 24, 2023
@rzats rzats deleted the rzatserkovnyi/makefile-update branch October 24, 2023 14:52
@melange396
Copy link
Collaborator

interesting approach, but this sidesteps looking up the user's API key which will reduce response time in a way thats not necessarily representative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korlaxxalrok korlaxxalrok korlaxxalrok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rzats @melange396 @korlaxxalrok