Properly handle parsing failure in FormulaEvaluator

[Dr15Jones]

Fixed a segmentation fault when the FormulaEvaluator was unable
to fully parse an expression which contained multiple binary
operators.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22354/3568

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CommonTools/Utils

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26319/console Started: 2018/02/26 17:00

[cmsbuild]

+1
Tested at: 8b117c5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22354/26319/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22354/26319/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22354/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2500248
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2500071
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.15999999995 KiB( 23 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[kirschen]

Resolved issue reported in
#21851

Thanks @Dr15Jones - very much appreciated!

[perrotta]

+1

• Technical, it does the job it is meant to. see Properly handle parsing failure in FormulaEvaluator #22354 (comment)

[fabiocos]

+1

[fabiocos]

merge