Implement formula evaluator #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the demo example, parser is 100x faster than TFormula Evaluator 2x faster
f770645 to
9e17983
Compare
Dr15Jones
reviewed
Jan 28, 2021
Dr15Jones
reviewed
Jan 28, 2021
| std::vector<int> variableIdx_; | ||
|
|
||
| static std::map<ParserType, peg::parser> parsers_; | ||
| static std::mutex parsers_mutex_; // could be one per parser, but this is good enough |
There was a problem hiding this comment.
Have you done large scale threading tests to see how this affect performance?
There was a problem hiding this comment.
No, but I hope the number of Formulas to compile is << the number of evaluations, so such contention is rare. Unless someone is doing something disgusting like re-loading the data each event...
There was a problem hiding this comment.
Further, the number of parsers is very small (currently 1)
There was a problem hiding this comment.
Actually the map is more or less pointless: if I wrapped the peg::parser with a shim class I could construct that as a static const member, rather than having the grammar text be the static const member.
Dr15Jones
reviewed
Jan 28, 2021
Dr15Jones
reviewed
Jan 28, 2021
Dr15Jones
reviewed
Jan 28, 2021
| throw std::runtime_error("Unrecognized AST node"); | ||
| } | ||
|
|
||
| double Formula::evaluate(const std::vector<Variable>& inputs, const std::vector<Variable::Type>& values) const { |
Dr15Jones
reviewed
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following https://github.com/nsmith-/correctionlib/discussions/17#discussioncomment-315714