Add ReverseDNSLookup in SnaffCon.cs to fix SnaffCon#161 for named tar…

…get IPs Reference: SnaffCon#161
cmprmsd · Oct 25, 2024 · 4377df2 · 4377df2
1 parent ba95a9f
commit 4377df2
Showing 1 changed file with 18 additions and 3 deletions.
diff --git a/SnaffCore/SnaffCon.cs b/SnaffCore/SnaffCon.cs
@@ -295,18 +295,33 @@ private void ShareDiscovery(string[] computerTargets)
                     // skip any that are in the exclusion list
                     continue;
                 }
+                // Reverse DNS lookup
+                var computerName = "";
+                try
+                {
+                    Mq.Trace("Performing reverse lookup for " + computer);
+                    IPHostEntry result = Dns.GetHostEntry(computer);
+                    computerName = result.HostName;
+                    Mq.Trace("Got DNSName " + computerName + " for " + computer);
+                }
+                catch (Exception e)
+                {
+                    Mq.Degub(e.Message);
+                    // Keep IP if Reverse Lookup fails
+                    computerName = computer;
+                }
                 // ShareFinder Task Creation - this kicks off the rest of the flow
-                Mq.Trace("Creating a ShareFinder task for " + computer);
+                Mq.Trace("Creating a ShareFinder task for " + computerName);
                 ShareTaskScheduler.New(() =>
                 {
                     try
                     {
                         ShareFinder shareFinder = new ShareFinder();
-                        shareFinder.GetComputerShares(computer);
+                        shareFinder.GetComputerShares(computerName);
                     }
                     catch (Exception e)
                     {
-                        Mq.Error("Exception in ShareFinder task for host " + computer);
+                        Mq.Error("Exception in ShareFinder task for host " + computerName);
                         Mq.Error(e.ToString());
                     }
                 });