Support for python3.10 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello Sergey, |
|
Awesome, thank you!
Sure, go ahead! |
|
Thank you very much !!!!! |
|
Thank you for releasing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Cyril,
First off, thank you for creating the package, after many years it's still being used in the Cloud9 IDE as a python debugger.
As mentioned in #13, the package fails to install on Python3.10 due to removal of
PyThreadState.use_tracing(python/cpython#87926).This pull request adds support for Python3.10 by conditionally setting
PyThreadState.use_tracingorPyThreadState.cframe.use_tracingdepending on the Python version.I tested it on Python3.6 and 3.10.
I also bumped the version to 1.4.2, I don't know if that's acceptable or you'd want to set it to 1.5.0 or something.
Any chance this PR can be merged and released to PyPI?
Regards,
Sergey