Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve withBase() method and deprecate withoutBase() method #173

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

clue
Copy link
Owner

@clue clue commented Jul 2, 2020

This changeset improves the withBase() method to be more consistent with other methods changing options and deprecates the withoutBase() method.

// old: deprecated
$browser = $browser->withoutBase();

// new
$browser = $browser->withBase(null);

Previously, each request method could potentially throw an Exception when the given absolute URL did not match any base URL configured. This will now simply ignore the base URL and use the given absolute URL as-is. This is not considered a BC break because this is undocumented behavior that is inconsistent with how the rest of this API works.

Builds on top of #172
Refs #154

@clue clue added this to the v2.9.0 milestone Jul 2, 2020
@clue clue merged commit e9526fc into clue:master Jul 2, 2020
@clue clue deleted the base branch July 2, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant