Improve withBase()
method and deprecate withoutBase()
method
#173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset improves the
withBase()
method to be more consistent with other methods changing options and deprecates thewithoutBase()
method.Previously, each request method could potentially throw an
Exception
when the given absolute URL did not match any base URL configured. This will now simply ignore the base URL and use the given absolute URL as-is. This is not considered a BC break because this is undocumented behavior that is inconsistent with how the rest of this API works.Builds on top of #172
Refs #154